Skip to content

Build insert statement with context's quote style#631

Merged
williamdes merged 1 commit intophpmyadmin:5.11.xfrom
MoonE:build-insert-ansi
Apr 2, 2026
Merged

Build insert statement with context's quote style#631
williamdes merged 1 commit intophpmyadmin:5.11.xfrom
MoonE:build-insert-ansi

Conversation

@MoonE
Copy link
Copy Markdown
Contributor

@MoonE MoonE commented Aug 23, 2025

Fixes #630

@MoonE MoonE changed the base branch from master to 5.11.x August 23, 2025 04:57
@MoonE MoonE force-pushed the build-insert-ansi branch 4 times, most recently from 76345d4 to 53b2636 Compare August 23, 2025 05:25
@MoonE MoonE force-pushed the build-insert-ansi branch from 53b2636 to 234f96f Compare August 23, 2025 05:30
Copy link
Copy Markdown
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
is there some other files that will need changes?

@MoonE
Copy link
Copy Markdown
Contributor Author

MoonE commented Aug 23, 2025

I had a look but didn't see any other hard-coded back ticks.

@williamdes williamdes self-assigned this Apr 2, 2026
@williamdes williamdes merged commit 0195e94 into phpmyadmin:5.11.x Apr 2, 2026
20 of 21 checks passed
@williamdes williamdes removed the request for review from MauricioFauth April 2, 2026 19:27
@williamdes williamdes added this to the 5.11.2 milestone Apr 2, 2026
@MoonE MoonE deleted the build-insert-ansi branch April 2, 2026 19:28
williamdes added a commit that referenced this pull request Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid back ticks on INSERT INTO columns with mode POSTGRESQL

2 participants